fix: add missing error-crypt.h include in pico.c for BAD_FUNC_ARG#10774
Open
srpatcha wants to merge 1 commit into
Open
fix: add missing error-crypt.h include in pico.c for BAD_FUNC_ARG#10774srpatcha wants to merge 1 commit into
srpatcha wants to merge 1 commit into
Conversation
Commit 30cb25e added a BAD_FUNC_ARG return to wc_pico_rng_gen_block() but did not add the required #include for wolfssl/wolfcrypt/error-crypt.h, causing a compile error when WOLFSSL_RPIPICO is defined. Fixes wolfSSL#10741
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit 30cb25e added a \BAD_FUNC_ARG\ return to \wc_pico_rng_gen_block()\ but did not add the required #include <wolfssl/wolfcrypt/error-crypt.h>, causing a compile error when \WOLFSSL_RPIPICO\ is defined:
\
wolfssl/wolfcrypt/src/port/rpi_pico/pico.c:45:16: error: 'BAD_FUNC_ARG' undeclared (first use in this function)
\\
Fix
Add #include <wolfssl/wolfcrypt/error-crypt.h>\ alongside the existing \ ypes.h\ include.
Testing
Fixes #10741