Skip to content

hostap CI tests: incorporate internal retries #10403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 1 commit into from
May 6, 2026
Merged

hostap CI tests: incorporate internal retries #10403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/hostap-vm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,27 @@ jobs:
KVMARGS="-cpu host"
EOF
git config --global --add safe.directory $GITHUB_WORKSPACE/hostap
# parallel-vm.py exits non-zero whenever any test failed on its first
# attempt, even if hostap's own internal retry recovered. Treat
# "All failed cases passed on retry" as success so we don't churn the
# whole VM batch over a flaky test that already passed on retry.
run_hwsim() {
local log rc=0
log=$(mktemp)
./vm/parallel-vm.py ${{ env.hostap_debug_flags }} --nocurses "$@" 2>&1 | tee "$log"
rc=${PIPESTATUS[0]}
if [ "$rc" -ne 0 ] && grep -q "All failed cases passed on retry" "$log"; then
echo "Treating run as success: hostap's internal retry recovered all failures"
rc=0
fi
rm -f "$log"
return $rc
}
# Run tests in increments of 200 to not stall out the parallel-vm script
while mapfile -t -n 200 ary && ((${#ary[@]})); do
TESTS=$(printf '%s\n' "${ary[@]}" | tr '\n' ' ')
HWSIM_RES=0 # Not set when command succeeds
./vm/parallel-vm.py ${{ env.hostap_debug_flags }} --nocurses $(nproc) $TESTS || HWSIM_RES=$?
run_hwsim $(nproc) $TESTS || HWSIM_RES=$?
# Retry failing tests up to 2 times to mitigate flakiness in the
# upstream hostap tests themselves.
for i in 1 2; do
Expand All @@ -359,7 +375,7 @@ jobs:
printf 'failed tests (retry %d): %s\n' "$i" "$FAILED_TESTS"
rm -rf /tmp/hwsim-test-logs
HWSIM_RES=0
./vm/parallel-vm.py ${{ env.hostap_debug_flags }} --nocurses $(nproc) $FAILED_TESTS || HWSIM_RES=$?
run_hwsim $(nproc) $FAILED_TESTS || HWSIM_RES=$?
fi
done
if [ "$HWSIM_RES" -ne "0" ]; then
Expand Down
Loading