Skip to content

F-1289 F-1718 F-1707 oob write and null pointer fixes#579

Open
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:f-1289-1718-1707-fixes
Open

F-1289 F-1718 F-1707 oob write and null pointer fixes#579
stenslae wants to merge 1 commit into
wolfSSL:masterfrom
stenslae:f-1289-1718-1707-fixes

Conversation

@stenslae

Copy link
Copy Markdown
Member
  • F-1718 and F-1701: Out-of-bounds array write with negative index from failed wolfSSL_read
  • F-1289: Wrong variable checked after wolfSSL_new()

@stenslae stenslae self-assigned this Jun 25, 2026

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #579

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
Findings: 2
1 finding(s) posted as inline comments (see file-level comments below)

Low (1)

Server wolfSSL_new() result still checks wrong variable

File: tls/memory-tls.c:188
Function: main
Category: NULL pointer dereference

The F-1289 fix corrected the client check to cli_ssl, but the identical server-side instance in main() still tests srv_ctx == NULL instead of srv_ssl, so a failed wolfSSL_new(srv_ctx) goes undetected and a NULL srv_ssl is passed to wolfSSL_accept.

Recommendation: Change the check to if (srv_ssl == NULL).

Referenced code: tls/memory-tls.c:188-189 (2 lines)


This review was generated automatically by Fenrir. Findings are non-blocking.

Comment thread dtls/client-dtls.c Outdated
Comment thread dtls/client-dtls.c Outdated
@stenslae stenslae force-pushed the f-1289-1718-1707-fixes branch from a4ea301 to 2318302 Compare June 25, 2026 21:58

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #579

Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src

No new issues found in the changed files. ✅

@stenslae stenslae assigned wolfSSL-Bot and stenslae and unassigned stenslae Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants