Skip to content

Make the random generator of _Rsa and RsaPublic configurable. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roberthdevries wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −7
Open

Make the random generator of _Rsa and RsaPublic configurable. #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions wolfcrypt/ciphers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,13 +650,16 @@ class _Rsa(object): # pylint: disable=too-few-public-methods
_mgf = None
_hash_type = None

def __init__(self):
def __init__(self, rng=None):
if rng is None:
rng = Random()

self.native_object = _ffi.new("RsaKey *")
ret = _lib.wc_InitRsaKey(self.native_object, _ffi.NULL)
if ret < 0: # pragma: no cover
raise WolfCryptError("Invalid key error (%d)" % ret)

self._random = Random()
self._random = rng
if _lib.RSA_BLINDING_ENABLED:
ret = _lib.wc_RsaSetRNG(self.native_object,
self._random.native_object)
Expand Down Expand Up @@ -690,13 +693,13 @@ def _get_mgf(self):


class RsaPublic(_Rsa):
def __init__(self, key=None, hash_type=None):
def __init__(self, key=None, hash_type=None, rng=None):
super().__init__(rng)

if key is not None:
key = t2b(key)
self._hash_type = hash_type

_Rsa.__init__(self)

idx = _ffi.new("word32*")
idx[0] = 0
Copy link
Copy Markdown
Contributor

@dgarske dgarske Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 [Medium] RsaPrivate.__init__ not updated to accept/forward rng parameter
💡 SUGGEST api

The PR's stated goal is to make the random generator of _Rsa and RsaPublic configurable. However, RsaPrivate.__init__ (line 849) was not updated to accept an rng parameter, and its call to _Rsa.__init__(self) on line 851 still relies on the default. Since RsaPrivate extends RsaPublic, users would reasonably expect RsaPrivate to also support a configurable RNG. Additionally, RsaPrivate.make_key (line 829) and RsaPublic.from_pem (line 718) also don't forward an rng parameter, leaving the configurability incomplete.

Suggestion:

Suggested change
idx[0] = 0
def __init__(self, key=None, hash_type=None, rng=None): # pylint: disable=super-init-not-called
if rng is None:
rng = Random()
_Rsa.__init__(self, rng) # pylint: disable=non-parent-init-called

Copy link
Copy Markdown
Contributor Author

@roberthdevries roberthdevries Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rng parameter is also added to the class RsaPrivate and passed to _Rsa.__init__()


Expand Down Expand Up @@ -842,9 +845,9 @@ def make_key(cls, size, rng=Random(), hash_type=None):

return rsa

def __init__(self, key=None, hash_type=None): # pylint: disable=super-init-not-called
def __init__(self, key=None, hash_type=None, rng=None): # pylint: disable=super-init-not-called

_Rsa.__init__(self) # pylint: disable=non-parent-init-called
_Rsa.__init__(self, rng) # pylint: disable=non-parent-init-called
self._hash_type = hash_type
idx = _ffi.new("word32*")
idx[0] = 0
Expand Down
Loading