Fix missing AES initialization in krb5 kdf#378
Open
night1rider wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix missing AES initialization in krb5 kdf#378night1rider wants to merge 1 commit intowolfSSL:masterfrom
night1rider wants to merge 1 commit intowolfSSL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Aesstruct inwp_kdf_krb5kdf_deriveis never initialized withwc_AesInit. In the unit test (will using FIPs)wc_AesCbcEncryptde-references uninitialized internal pointers causing a segfault. Additionallywc_AesFreeis called unconditionally at the end, so early-exit error paths (wrong key size etc.) also segfault on the uninitialized struct. Not sure if this happens without FIPs but the AES struct should be initialized before possible usage.