Fix Fenrir Issues in wolfProvider extend test suite coverage#377
Open
aidangarske wants to merge 3 commits intowolfSSL:masterfrom
Open
Fix Fenrir Issues in wolfProvider extend test suite coverage#377aidangarske wants to merge 3 commits intowolfSSL:masterfrom
aidangarske wants to merge 3 commits intowolfSSL:masterfrom
Conversation
…14, 829, 830, 836, 837, 838, 839, 1183, 1184, 1185, 1186, 1187, 1280, 1281 for wolfProvider
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- wp_drbg_reseed: Replace parentClearSeed callback with OPENSSL_clear_free(seed, seedLen) - wp_drbg_reseed: Same fix as above — securely wipes and frees the seed buffer - wp_ecx_dup: Remove dead ok variable; when private key not selected, re-init the key and import only public part to avoid leaking private material - wp_rsa_kmgmt.c: SHA1 fallback replaced with ok = 0 error — unknown digest is now a failure, not a silent fallback - wp_hmac.c: Remove unused rc variable and (void)rc - wp_cmac.c: Add keyLen <= sizeof(dst->key) bounds check before XMEMCPY - test_tls_cbc.c: Check RAND_bytes() return value
Member
Author
|
Jenkins retest this please As per Jenkins supervisor the build is still failing from cloud node termination which is unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
169, 170, 171, 172, 271, 395, 396, 510, 511, 512, 514, 829, 830, 836, 837, 838, 839, 1183, 1184, 1185, 1186, 1187, 1280, 1281New Tests
#514: Partial HMAC update, dup context, feed different tails to each, verify both MACs match independently computed expected values#837: Create HMAC keys with same and different material, verify EVP_PKEY_eq returns match for same keys and non-match for different keys#1186: DigestSign partial update, copy context mid-stream, diverge with different data, verify both MACs match expected values#836: Same pattern as test_hmac_dup but for CMAC with AES-256-CBC cipher#838: DES3-CBC encrypt/decrypt roundtrip with all padding sizes (1-8), cross-provider interop in both directions#169, #170: Create SEED-SRC/CTR-DRBG hierarchy, generate, reseed with NULL entropy, generate again and verify output differs, the uninstantiate and call verify_zeroization#1184: Generate RSA-PSS key with SHA-256 signing digest and SHA-384 MGF1 digest, verify EVP_PKEY_get_params returns the MGF1 digest (384) not the signing digest (256)#395, #396: Generate RSA-2048 key, encapsulate with RSASVE, decapsulate, verify recovered secret matches original#1281: Load Ed25519/Ed448 key from DER, EVP_PKEY_dup, verify EVP_PKEY_eq, bidirectional sign/verify between original and duplicate