Fix SHA-512 Finalize Re-Init Error Overwrite#311
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts wh_Client_Sha512 to avoid overwriting an existing ret value when re-initializing SHA-512 variants after finalize, by explicitly discarding init return values.
Changes:
- Replaced assignments to
retfromwc_InitSha512*_excalls with(void)casts to preserve any previously-set error code. - Standardized the “intentionally unused return value” pattern across SHA-512 variant init calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bigbrett
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor change to the
wh_Client_Sha512function insrc/wh_client_crypto.cby discarding the return values of hash initialization functions, instead of assigning them toret. This simplifies the code and indicates that the return values are intentionally unused.