F-644: fix read of exactly MAX_LEN bytes treated as error#214
Merged
dgarske merged 3 commits intowolfSSL:mainfrom Apr 10, 2026
Merged
F-644: fix read of exactly MAX_LEN bytes treated as error#214dgarske merged 3 commits intowolfSSL:mainfrom
dgarske merged 3 commits intowolfSSL:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a decryption regression in the non-EVP crypto path where a successful XFREAD() returning exactly MAX_LEN bytes was incorrectly treated as an error, and extends shell test coverage to catch the boundary condition.
Changes:
- Adjust
wolfCLU_decrypt()to treat any positive-lengthXFREAD()result (including exactlyMAX_LEN) as success. - Add an encrypt/decrypt round-trip test (Camellia, non-EVP path) that exercises multi-chunk reads.
- Broaden OCSP interop test log matching for “invalid file” error text across implementations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/ocsp/ocsp-interop-test.sh | Expands expected error-message pattern matching for invalid certificate file test. |
| tests/encrypt/enc-test.sh | Adds Camellia round-trip test intended to exercise MAX_LEN read boundary behavior in non-EVP decrypt path. |
| src/x509/clu_x509_sign.c | Updates preprocessor gating for additional hash enum cases; whitespace-only adjustments nearby. |
| src/crypto/clu_decrypt.c | Fixes handling of XFREAD() returning exactly MAX_LEN bytes so it is not treated as failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7e1ae69 to
764da36
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
764da36 to
7f91683
Compare
dgarske
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "Successful read of exactly MAX_LEN bytes treated as error"
Add test coverage
Depend on : #211 (Fixed)
Depend on : #219