wolfPKCS11 test

[danielinux]

• move pkcs11/tz test to its own module in test-app
• add m33mu two-runs test for persistent storage coverage

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

Makefile:1

• This change removes the previous || true behavior, making signing failures stop the build. That’s a significant behavior change and isn’t mentioned in the PR description (which focuses on PKCS11 tests). If the intent is to make signing errors fatal, please call it out in the PR description; if not, consider restoring the prior non-fatal behavior for this target.

## wolfBoot Makefile

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In cleanup you call C_Logout/C_CloseSession unconditionally even when session is still CK_INVALID_HANDLE (e.g., if session open/login failed and you goto cleanup). Some PKCS#11 implementations treat an invalid handle as an error or may assert. Guard these calls with if (session != CK_INVALID_HANDLE) (and only logout if login succeeded).

Suggested change

	(void)wolfpkcs11nsFunctionList.C_Logout(session);
	(void)wolfpkcs11nsFunctionList.C_CloseSession(session);
	if (session != CK_INVALID_HANDLE) {
	(void)wolfpkcs11nsFunctionList.C_Logout(session);
	(void)wolfpkcs11nsFunctionList.C_CloseSession(session);
	}

[Copilot]

The WOLFCRYPT_TZ_PKCS11 block adds PKCS#11 sources/defines even when TZEN is OFF, but test_pkcs11.c includes user_settings.h which is provided via the wcs include directory that you only add under if(TZEN). This makes the CMake build inconsistent with the Makefile (which only builds PKCS#11 test code when TZEN=1) and can break configurations that enable WOLFCRYPT_TZ_PKCS11 without TZEN. Consider nesting this block under if(TZEN AND WOLFCRYPT_TZ_PKCS11) or emitting a FATAL_ERROR when WOLFCRYPT_TZ_PKCS11 is set without TZEN.