Conversation
wled00/FX.cpp
Outdated
| uint16_t cx2 = beatsin8(17-speed,0,cols-1)*scale; | ||
| uint16_t cy2 = beatsin8(14-speed,0,rows-1)*scale; | ||
|
|
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
I agree with @softhack007 to remove all changes not related to the added font in Scrolling text mode.
Also reduce reducing the size of font array would be wise as characters above 126 are not supported (only ASCII are) by the display function..
ItRainsSmiles
force-pushed
the
feature/add_5x3_font
branch
from
98eb5e3 to
119f15a
Compare
ItRainsSmiles
force-pushed
the
feature/add_5x3_font
branch
from
119f15a to
70972ab
Compare
|
Please do not force push any more commits. |
Done :) @blazoncek |
okay :) @blazoncek |
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
Font still includes characters beyond 0x7F.
wled00/src/font/clear_3x5.h
Outdated
| 0x80, 0x80, 0x00, 0x80, 0x80, /* 0x7C bar */ | ||
| 0xC0, 0x40, 0x20, 0x40, 0xC0, /* 0x7D braceright */ | ||
| 0x60, 0xC0, 0x00, 0x00, 0x00, /* 0x7E asciitilde */ | ||
| 0x80, 0x00, 0x80, 0x80, 0x80, /* 0xA1 exclamdown */ |
There was a problem hiding this comment.
Fonts from here on are unnecessary and only consume flash space.
softhack007
left a comment
softhack007
left a comment
There was a problem hiding this comment.
Looks much better now, thanks.
As the author says he edited many characters himself, I think we can accept the licensing situation as-is.
Approved from my side 👍
|
@blazoncek I guess this one is low-risk so it could go into -b5, what do you think? |
|
Yes, but we also need to see the increase of binary size (you may have issues with plenty of usermods, etc). |
softhack007
left a comment
softhack007
left a comment
There was a problem hiding this comment.
small change to make sure the char array has enough entries.
| 0xA0, 0xE0, 0xE0, 0xE0, 0x00, /* 0x77 w */ | ||
| 0xA0, 0x40, 0x40, 0xA0, 0x00, /* 0x78 x */ | ||
| 0xA0, 0xA0, 0x60, 0x20, 0x40, /* 0x79 y */ | ||
| 0xE0, 0x60, 0xC0, 0xE0, 0x00, /* 0x7A z */ |
There was a problem hiding this comment.
I think you deleted a few too much now...
WLED expects the array to have all chars from 0x20 thru 0x7E
if (chr < 32 || chr > 126) return; // only ASCII 32-126 supported
So your table needs to have everything up to 126 = 0x7E.
Please re-add the missing 4 chars. We want to avoid crashing due to array-out-of-bounds read.
|
Just checked Flash size increase from this PR:
|
|
@ItRainsSmiles can you please rebase this PR for 0_15 branch? |
blazoncek
added
keep
|
this will become possible with #5372 so once that is done, this can be closed. |
4 participants
In order to support more shown digits on small matrix sizes, the font arsenal has been expanded to a tiny 5x3 font.
This font's main strengths are the digits, which have been edited for a tiny but clear appearance, which is very useful for a clock.
There are no free spaces between the digits.