Update ethernet-lan.md#212
Conversation
add note regarding GPIO0 clock output and LAN87xx add documentation for adding custom PCB with ethernet to the WLED build
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
I'd like a few things to be modified.
| - Ethernet standard requires that the ethernet lines including shield are isolated form the electronics and for EMC reason ceramic capacitor (rated for 2 kV) is connected between Ethernet shield and electronics ground. Unfortunately, many simple/cheap ethernet adapters do not fulfill these requirements. Be careful using them. | ||
| - Ethernet standard requires that the ethernet lines including shield are isolated form the electronics and for EMC reasons a ceramic capacitor (rated for 2 kV) should be connected between Ethernet shield and electronics ground. Unfortunately, many simple/cheap ethernet adapters do not fulfill these requirements. Be careful using them. | ||
| - Most of Ethernet based controllers/ adapters are based on LAN87xx IC. It requires proper reset line. Unfortunately, some simple/cheap adapters do not implement this line correctly that might lead to instabilities especially during boot up. | ||
| - ESP32 can be configured to provide the 50MHz clock for the PHY on GPIO0, GPIO16 or GPIO17. For operation with LAN87xx IC, use GPIO17. If you want to use GPIO0 with LAN87xx, you will need to add an inverter between GPIO0 and the LAN87xx CLKIN pin. |
There was a problem hiding this comment.
This information is clearly stated in Espressif documentation and a reference to it should be added here if you want this text to be included.
https://docs.espressif.com/projects/esp-idf/en/v5.1/esp32/hw-reference/esp32/get-started-ethernet-kit.html#rmii-clock-sourced-internally-from-esp32-s-apll
| [WESP32](https://wesp32.com/) | | 0, 16, 17 | ||
| [WT32-ETH01](https://www.seeedstudio.com/Ethernet-module-based-on-ESP32-series-WT32-ETH01-p-4736.html) | | 0, 16, 18, 23 | ||
|
|
||
| ## Defining GPIO for a custom PCBA |
There was a problem hiding this comment.
Misleading or incorrectly worded heading.
IMO it should read: Creating custom/new Ethernet board option in WLED
|
|
||
| ## Defining GPIO for a custom PCBA | ||
|
|
||
| The following PHY are supported by WLED according to the header ETH.h: |
There was a problem hiding this comment.
ETH.h is not part of WLED and WLED does not support anything but LAN8720A and IP101.
| settings_wifi.htm | 221 | add your board name and enum index | ||
|
|
||
|
|
||
| note that you will need to recompile the html, see [Changing web UI for instruction](https://github.com/Aircoookie/WLED/wiki/Add-own-functionality/a30b2f3004c9aafc0639138afbff73b4efe4a766) |
There was a problem hiding this comment.
This is no longer necessary in 0.15 as it is done automatically if the environment is set up correctly.
There was a problem hiding this comment.
Agreed, the "recompile html" note can be deleted entirely. This step is done automatically now when compiling wled.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 56 minutes and 21 seconds.Comment |
| - Ethernet standard requires that the ethernet lines including shield are isolated form the electronics and for EMC reason ceramic capacitor (rated for 2 kV) is connected between Ethernet shield and electronics ground. Unfortunately, many simple/cheap ethernet adapters do not fulfill these requirements. Be careful using them. | ||
| - Ethernet standard requires that the ethernet lines including shield are isolated form the electronics and for EMC reasons a ceramic capacitor (rated for 2 kV) should be connected between Ethernet shield and electronics ground. Unfortunately, many simple/cheap ethernet adapters do not fulfill these requirements. Be careful using them. | ||
| - Most of Ethernet based controllers/ adapters are based on LAN87xx IC. It requires proper reset line. Unfortunately, some simple/cheap adapters do not implement this line correctly that might lead to instabilities especially during boot up. | ||
| - ESP32 can be configured to provide the 50MHz clock for the PHY on GPIO0, GPIO16 or GPIO17. For operation with LAN87xx IC, use GPIO17. If you want to use GPIO0 with LAN87xx, you will need to add an inverter between GPIO0 and the LAN87xx CLKIN pin. |
There was a problem hiding this comment.
It might be worth to add a warning note here because the clock output from esp32 can be unstable, and may interfere badly with esp-now and wifi operations including AP mode (see wled/WLED#4703). Also audioreactive may not work well with aux-in ( MCLK output unstable) when ethernet clock is generate by the esp32.
3 participants
I recently had some trouble getting a custom PCBA with LAN8720A working with WLED. Having got it working, I wanted to update the documentation to make it easier for those who come after me to not make the same mistakes.