fix(customrow): only attach BottomTabs custom row to NavigationActivity#8336
Open
Yoavpagir wants to merge 1 commit into
Open
fix(customrow): only attach BottomTabs custom row to NavigationActivity#8336Yoavpagir wants to merge 1 commit into
Yoavpagir wants to merge 1 commit into
Conversation
BottomTabsCustomRowAttacher is a global Application.ActivityLifecycleCallbacks that ran tryAttach()/findViewById() on every activity in the process. On a foreign, non-AppCompat-themed activity (e.g. AppAuth RedirectUriReceiverActivity during OAuth login) this forces AppCompat sub-decor inflation and crashes with 'You need to use a Theme.AppCompat theme'. Guard so the observer only touches RNN's own NavigationActivity, where BottomTabs actually live. Sentry: WIX-ONE-APP-9GFHV
Yoavpagir
marked this pull request as ready for review
July 21, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Owner (Android) crashes during OAuth login. When AppAuth's
RedirectUriReceiverActivity(the relay that receives the OAuth redirect) is created, the app dies with:Sentry: WIX-ONE-APP-9GFHV — ~5.9k events / 1.6k users, Android-only, still active.
Root cause
BottomTabsCustomRowAttacheris a globalApplication.ActivityLifecycleCallbacksand runstryAttach()→findViewById(android.R.id.content)on every activity in the process. For a foreign, non-AppCompat-themed activity (AppAuth's relay), thatfindViewByIdforcesAppCompatDelegatesub-decor inflation, which requires aTheme.AppCompatand throws. Any third-party non-AppCompat activity (OAuth relays, SDK login flows, etc.) hits this, not just AppAuth.Fix
Guard the observer to RNN's own
NavigationActivity— the only placeBottomTabs(and thus the custom row) ever live. Foreign activities are skipped, sofindViewByIdis never called on them.Verification
Built the
playgroundapp with this change and reproduced the exact mechanism on a rooted emulator: launching a non-AppCompat-themedAppCompatActivityinto the running process no longer crashes (unpatched: process dies with the stack above). The custom bottom-tabs feature still renders correctly onNavigationActivity— no regression.