Skip to content

playground: regenerate Android buttons navbar snapshot#8333

Merged
yedidyak merged 1 commit into
masterfrom
yedidyak/regenerate-buttons-navbar-android-snapshot
Jun 23, 2026
Merged

playground: regenerate Android buttons navbar snapshot#8333
yedidyak merged 1 commit into
masterfrom
yedidyak/regenerate-buttons-navbar-android-snapshot

Conversation

@yedidyak

Copy link
Copy Markdown
Contributor

Summary

  • Regenerate playground/e2e/assets/buttons_navbar.android.png from the current Android Buttons screen rendering on master
  • Refresh the snapshot to match the current top-bar layout after the recent Android custom-button measurement changes
  • Keep the change scoped to the Android PNG asset only

Validation

  • rtk ./gradlew app:generateCodegenArtifactsFromSchema react-native-webview:generateCodegenArtifactsFromSchema d11_react-native-fast-image:generateCodegenArtifactsFromSchema react-native-community_datetimepicker:generateCodegenArtifactsFromSchema react-native-gesture-handler:generateCodegenArtifactsFromSchema --no-daemon
  • rtk npx detox build --configuration android.emu.release
  • adb exec-out screencap -p on the Android emulator, cropped to the top-bar bounds (1080x154 at y=66)
  • SSIM check between the regenerated asset and the fresh crop: 1.000000000000

Not Run

  • rtk npx detox test --configuration android.emu.release e2e/Buttons.test.js --testNamePattern "should render top/navigation-bar buttons in the right order" --headless -w 1 --retries 2
    This remained blocked locally by an emulator window-focus issue caused by a system Bluetooth keeps stopping dialog, so the snapshot was regenerated from a stable adb capture instead.

Risks

  • Low: snapshot-only change with no source-code modifications
  • The main risk is that local adb capture could differ slightly from CI rendering, though it was taken from the current release build on the configured Android emulator

Review Context

  • The failing CI case compares the whole Android top bar against buttons_navbar.android.png, so this refresh aligns the expected artifact with the current UI
  • I did not change the e2e test itself because the failure points to stale snapshot data rather than test logic

Suggested Reviewers

  • @markdevocht — prior editor of this snapshot path and the closest non-author owner in git history for playground/e2e/assets/buttons_navbar.android.png

@yedidyak yedidyak merged commit c9bbcb2 into master Jun 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant