Avoid root lodash import for includes - #2789
Draft
wanxiankai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includesfromlodash/includesinCalendarProviderlodashmodule into Expo web bundles for this single helperCloses #2788.
Why
CalendarProvideronly needs theincludeshelper. Importing it from the lodash package root can cause Metro web builds to include the fulllodash/lodash.jsmodule, as reported in the issue. The package already useslodash/includesin nearby code, so this keeps the behavior the same while matching the existing import pattern.Test plan
YARN_GLOBAL_FOLDER=$PWD/.yarn/local-global YARN_ENABLE_SCRIPTS=false yarn installyarn build:devyarn lint(passes with existing warnings)yarn unit --runInBand --watchman=false(10 suites passed, 151 tests passed, 10 skipped)git diff --checkNote: plain
yarn unit --runInBandhit the local macOS sandbox Watchman permission issue when Watchman tried to write~/Library/LaunchAgents/com.github.facebook.watchman.plist, so the full Jest suite was rerun with Watchman disabled.