feat(bindings): skip binding test on WSL2 for prebuilt CUDA binaries#601
Open
cyncuiuh8207 wants to merge 2 commits into
Open
feat(bindings): skip binding test on WSL2 for prebuilt CUDA binaries#601cyncuiuh8207 wants to merge 2 commits into
cyncuiuh8207 wants to merge 2 commits into
Conversation
WSL2 reports Ubuntu in /etc/os-release but the WSL-specific kernel environment causes binding tests to fail even when the prebuilt CUDA binary is actually compatible. Changes: - Add checkIfWSL2() in getLinuxDistroInfo.ts: reads /proc/sys/kernel/osrelease and checks for 'wsl2' or 'microsoft' substring - getLinuxDistroInfo() now returns wslDistro field - getPlatformInfo() propagates wslDistro to BinaryPlatformInfo type - getShouldTestBinaryBeforeLoading(): skip binding test when wslDistro=true Tested on WSL2 (Ubuntu 26.04, RTX 4070 Ti SUPER, CUDA prebuilt binary). Logic tests confirm WSL2 skips binding test while normal Linux does not. Closes WSL2 CUDA binding compatibility issue.
…verage - Add /usr/lib/os-release fallback to mock implementations - Add proper mock return values for each os-release path - Re-test in actual WSL2 environment: WSL2 detected, binding test skipped - Note: vitest shows Bus error in this environment (addon loading issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WSL2 reports Ubuntu in /etc/os-release but the WSL-specific kernel environment causes binding tests to fail even when the prebuilt CUDA binary is actually compatible.
Changes:
Tested on WSL2 (Ubuntu 26.04, RTX 4070 Ti SUPER, CUDA prebuilt binary). Logic tests confirm WSL2 skips binding test while normal Linux does not.
Closes WSL2 CUDA binding compatibility issue.
Description of change
Pull-Request Checklist
masterbranchnpm run formatto apply eslint formattingnpm run testpasses with this changeFixes #0000