Skip to content

feat: document AstroComponentLogger type#14203

Open
ronits2407 wants to merge 4 commits into
withastro:mainfrom
ronits2407:feat/logger-type
Open

feat: document AstroComponentLogger type#14203
ronits2407 wants to merge 4 commits into
withastro:mainfrom
ronits2407:feat/logger-type

Conversation

@ronits2407

@ronits2407 ronits2407 commented Jul 7, 2026

Copy link
Copy Markdown

Documents the exported type for the runtime logger. Related to withastro/astro#17313

@astrobot-houston

astrobot-houston commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@ronits2407 ronits2407 mentioned this pull request Jul 7, 2026
Open
@astrobot-houston

astrobot-houston commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/logger-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

ArmandPhilippot
ArmandPhilippot reviewed Jul 7, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a nit for the type and the AstroRuntimeLogger wasn't correctly formatted. You can see examples in our contributing guide: https://contribute.docs.astro.build/reference/api-references/

Comment thread src/content/docs/en/reference/logger-reference.mdx
Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
@ArmandPhilippot ArmandPhilippot added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jul 7, 2026
ronits2407 and others added 2 commits July 7, 2026 17:18
@ronits2407

ronits2407 commented Jul 7, 2026

Copy link
Copy Markdown
Author

the suggestion has been applied , let me know if i should do any more changes or if something is wrong

ArmandPhilippot
ArmandPhilippot approved these changes Jul 7, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome among docs contributors! LGTM. We'll wait for the other PR to be released before merging this.

Comment thread src/content/docs/en/reference/logger-reference.mdx
<p>

**Type:** `{ info: (message: string) => void; warn: (message: string) => void; error: (message: string) => void; }`<br />
<Since v="7.0.7" />

@ArmandPhilippot ArmandPhilippot Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a comment here to remind us that we'll need to double-check before merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ronits2407 @astrobot-houston @ArmandPhilippot