WPB-26474: extends code to meetings#5281
Open
blackheaven wants to merge 7 commits into
Open
Conversation
zebot
added
the
ok-to-test
akshaymankar
requested changes
Jun 22, 2026
| MakeKey ref -> case ref of | ||
| CodeReferentConv _ -> Code.mkKey ref | ||
| CodeReferentMeeting _ -> | ||
| error "CodeStore.Cassandra.MakeKey: meetings are not supported on cassandra" |
Member
There was a problem hiding this comment.
This would cause 500s, right? If so, we should handle this properly, so the error becomes a 4xx (maybe 404?) something to let the clients know that the server doesn't support this feature.
Comment on lines
+101
to
+104
| mkKeyId :: (MonadIO m) => Id a -> m Key | ||
| mkKeyId ident = do | ||
| sha256 <- liftIO $ fromJust <$> getDigestByName "SHA256" | ||
| pure $ Key . unsafeRange . Ascii.encodeBase64Url . BS.take 15 $ digestBS sha256 (toByteString' cnv) | ||
| pure $ Key . unsafeRange . Ascii.encodeBase64Url . BS.take 15 $ digestBS sha256 (toByteString' ident) |
Member
There was a problem hiding this comment.
Shouldn't we add something here to stop same meetingid and convid collide in the key id?
Contributor
Author
There was a problem hiding this comment.
I was thinking of prefixing keys like conv:<SHA> but I'm afraid it would break everything, WDYT?
Co-authored-by: Akshay Mankar <axeman@mailbox.org>
Co-authored-by: Akshay Mankar <axeman@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26474
Checklist
changelog.d