refactor: Reduce message list mapping and ViewModel scope overhead#4857
Open
MohamadJaara wants to merge 2 commits into
Conversation
Avoid eagerly parsing markdown documents when mapping text messages, cache mention display mapping across recompositions, and lazily compute formatted message timestamps. Add coverage to ensure markdown parsing is deferred to the UI layer.
Limit audio and asset local path scoped view model keys to the visible message window plus a small prefetch buffer instead of all loaded paging items. Keep the currently playing audio message in scope while playback is active.
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## mo/refactor/markdown-formating-while-mapping-conversaions #4857 +/- ##
=============================================================================================
+ Coverage 51.19% 51.23% +0.03%
=============================================================================================
Files 612 612
Lines 21172 21188 +16
Branches 3421 3421
=============================================================================================
+ Hits 10839 10855 +16
+ Misses 9318 9316 -2
- Partials 1015 1017 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Testing