Skip to content

feat: Display drive section for guests added to a team with drive enabled#4855

Open
ohassine wants to merge 3 commits into
Restrict-access-to-upload-for-Viewers-profilefrom
display-drive-section-for-guests-added-to-a-team-with-Drive-enabled
Open

feat: Display drive section for guests added to a team with drive enabled#4855
ohassine wants to merge 3 commits into
Restrict-access-to-upload-for-Viewers-profilefrom
display-drive-section-for-guests-added-to-a-team-with-Drive-enabled

Conversation

@ohassine
Copy link
Copy Markdown
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently Drive section is not displayed for guests

Solutions

Show it to guests if they are added to a conversation with drive enabled

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title Display drive section for guests added to a team with drive enabled feat: Display drive section for guests added to a team with drive enabled May 21, 2026
@ohassine ohassine requested review from sbakhtiarov and yamilmedina and removed request for yamilmedina May 21, 2026 10:34
@sonarqubecloud
Copy link
Copy Markdown

@ohassine ohassine requested a review from yamilmedina May 21, 2026 11:21
observeTeamManagementUrlForUser()
) { wireCellsEnabled, unreadArchiveConversationsCount, teamManagementUrl ->
observeTeamManagementUrlForUser(),
observeConversationListDetails.get().invoke(fromArchive = false)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

observeConversationListDetails is

  1. A complex query (I think we should avoid calling it unless absolutely necessary)
  2. Will change a lot (which will cause constant drawer items list rebuilds for no reason)

I suggest:

  • use existing hasConversationWithCell() query (make the observable version if needed).
  • create a use case for observing it which returns Flow with distinctUntilChanged() to avoid unnecessary updates and keep all business logic in kalium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants