Skip to content

fix: talkBack labels for message avatars and rich text actions [WPB-14771] [WPB-14767] [WPB-14773] [WPB-14812]#4792

Merged
Garzas merged 2 commits intodevelopfrom
kubaz/fix/talkback-avatar-rich-text-a11y
May 6, 2026
Merged

fix: talkBack labels for message avatars and rich text actions [WPB-14771] [WPB-14767] [WPB-14773] [WPB-14812]#4792
Garzas merged 2 commits intodevelopfrom
kubaz/fix/talkback-avatar-rich-text-a11y

Conversation

@Garzas
Copy link
Copy Markdown
Contributor

@Garzas Garzas commented May 6, 2026

https://wearezeta.atlassian.net/browse/WPB-14771


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • TalkBack announced duplicated role text for rich text editing actions, for example “Enable rich text mode button button”.
  • Message avatars were not properly exposed as profile-opening buttons when TalkBack was enabled.
  • Disabled/unavailable sender avatars could announce “open profile” even when opening the profile was not possible.

Causes (Optional)

  • Some accessibility strings included the word “button” while Compose also announced the Button role.
  • The avatar click target did not provide a dedicated TalkBack description and button semantics.
  • The avatar description appended the profile action label regardless of whether profile redirection was enabled.

Solutions

  • Removed explicit “button” wording from rich text and attachment action content descriptions.
  • Added avatar TalkBack semantics with a profile-focused content description and button role when the avatar is clickable.
  • Included “open profile” in the avatar description only when profile redirection is enabled.

@Garzas Garzas requested review from saleniuk and yamilmedina May 6, 2026 10:55
@Garzas Garzas self-assigned this May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.13%. Comparing base (e325dd1) to head (345dce0).
⚠️ Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4792      +/-   ##
===========================================
+ Coverage    51.05%   51.13%   +0.07%     
===========================================
  Files          606      610       +4     
  Lines        21045    21089      +44     
  Branches      3394     3399       +5     
===========================================
+ Hits         10744    10783      +39     
+ Misses        9292     9291       -1     
- Partials      1009     1015       +6     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e325dd1...345dce0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ar/UserProfileAvatar.kt

Co-authored-by: Michał Saleniuk <30429749+saleniuk@users.noreply.github.com>
@Garzas Garzas requested a review from saleniuk May 6, 2026 13:21
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@Garzas Garzas added this pull request to the merge queue May 6, 2026
Merged via the queue into develop with commit 3d2f223 May 6, 2026
16 of 17 checks passed
@Garzas Garzas deleted the kubaz/fix/talkback-avatar-rich-text-a11y branch May 6, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants