test(ts-browser): use globalThis instead of window#2277
Open
fewerner wants to merge 4 commits into
Open
Conversation
By declaring helpers and ccModule as global fields we don't have to access them via window. `Window` holds the same fields as `GlobalThis`. It is defined as: ```typescript declare var window: Window & typeof globalThis; ``` GlobalThis works on browser and node. We can access all global definitions directly, via globalThis, and window in browser.
Instead we just access global fields directly. This is a purely mechanical change.
First access of globals without using globalThis results in errors. I assume that the first access creates a runtime binding that on following calls resolves fine without using globalThis.
Less globals is better. We can just use the getter from our API instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR declares window variables as globals and avoids accessing them via window.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.