Skip to content

Improved Ukrainian translation#1467

Merged
LukeTowers merged 1 commit intowintercms:developfrom
gviabcua:patch-2
Mar 12, 2026
Merged

Improved Ukrainian translation#1467
LukeTowers merged 1 commit intowintercms:developfrom
gviabcua:patch-2

Conversation

@gviabcua
Copy link
Contributor

@gviabcua gviabcua commented Mar 12, 2026

Improved Ukrainian translation, add new Ukrainian language strings

Summary by CodeRabbit

  • Documentation
    • Expanded Ukrainian language support with new translations for admin, form, editor, and relation features including password generation, superuser controls, login throttling, form preview, code editor options, search prompts, and import/export actions.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Walkthrough

This PR adds new translation keys to the Ukrainian language file, introducing strings for color validation feedback, password auto-generation, superuser management and throttling controls, form UI elements (preview, create-and-new), record finder prompts, editor features (folding, bracket colors, minimap, fullscreen), and CSV import/export labels.

Changes

Cohort / File(s) Summary
Ukrainian Language Translations
modules/backend/lang/uk/lang.php
Added 38 new translation keys across multiple sections: field validation (colors_invalid_input), user management (auto_generate_password, escalation/superuser/throttle-related strings), form UI (preview, create_and_new), record finder (default_prompt), relation widget (missing_behavior, refresh), reorder (reorder_title), editor options (enable_folding, bracket_colors, show_colors, show_minimap, toggle_fullscreen), and import/export (export, import labels).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding new Ukrainian translation strings to the lang.php file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
modules/backend/lang/uk/lang.php (1)

170-171: Keep the “superuser” term consistent with the rest of the Ukrainian UI.

These two messages switch to суперкористувач, but the existing user.superuser label in this file is already translated as Супер-адміністратор. Reusing the established term will avoid UI inconsistency.

Suggested wording
-        'self_escalation_denied' => 'Ви не можете змінювати власну роль, дозволи чи статус суперкористувача.',
-        'superuser_grant_denied' => 'Тільки суперкористувачі можуть надавати статус суперкористувача або змінювати облікові записи інших суперкористувачів.',
+        'self_escalation_denied' => 'Ви не можете змінювати власну роль, дозволи чи статус супер-адміністратора.',
+        'superuser_grant_denied' => 'Лише супер-адміністратори можуть надавати статус супер-адміністратора або змінювати облікові записи інших супер-адміністраторів.',
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@modules/backend/lang/uk/lang.php` around lines 170 - 171, The two translation
entries self_escalation_denied and superuser_grant_denied use "суперкористувач",
which is inconsistent with the existing user.superuser label; update those
message strings to use the established term "Супер-адміністратор" (keeping
surrounding punctuation and capitalization consistent) so the UI uses the same
phrase everywhere.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@modules/backend/lang/uk/lang.php`:
- Line 398: The translation string for the 'csrf' key incorrectly refers to
"cross-site scripting"; update the value for the 'csrf' entry in
modules/backend/lang/uk/lang.php so it mentions forged cross-site requests /
CSRF (e.g., підроблені міжсайтові запити or підробку міжсайтових запитів)
instead of cross-site scripting, keeping the rest of the warning intact and
preserving punctuation and encoding.
- Line 280: The translation string for the key 'create_and_new' is currently
"Створити та нове", which is ungrammatical for a CTA; update the value for
'create_and_new' in lang.php to a natural Ukrainian button label such as
"Створити та додати ще" or "Створити й додати ще один" so it reads correctly as
"create and add another" in the UI. Ensure you only change the right-hand string
for the 'create_and_new' entry and keep the key name intact.

---

Nitpick comments:
In `@modules/backend/lang/uk/lang.php`:
- Around line 170-171: The two translation entries self_escalation_denied and
superuser_grant_denied use "суперкористувач", which is inconsistent with the
existing user.superuser label; update those message strings to use the
established term "Супер-адміністратор" (keeping surrounding punctuation and
capitalization consistent) so the UI uses the same phrase everywhere.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3052fa8-3ef4-4bb9-a301-a36d7e0e9de5

📥 Commits

Reviewing files that changed from the base of the PR and between 555e67c and 8abfbcd.

📒 Files selected for processing (1)
  • modules/backend/lang/uk/lang.php

@LukeTowers LukeTowers added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Mar 12, 2026
@LukeTowers LukeTowers added this to the 1.2.13 milestone Mar 12, 2026
@LukeTowers LukeTowers changed the title Improved Ukrainian translation, add new Ukrainian language strings Improved Ukrainian translation Mar 12, 2026
@LukeTowers LukeTowers merged commit 2a342f9 into wintercms:develop Mar 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants