Skip to content

don't resolve symlinks when backing up (..)#1134

Merged
maartenbreddels merged 2 commits intowidgetti:masterfrom
kmdalton:master
Apr 21, 2026
Merged

don't resolve symlinks when backing up (..)#1134
maartenbreddels merged 2 commits intowidgetti:masterfrom
kmdalton:master

Conversation

@kmdalton
Copy link
Copy Markdown
Contributor

@kmdalton kmdalton commented Dec 23, 2025

This my attempt to resolve #1133

Changes to / New Features:

  • I included docs for (the changes to) my feature.
  • I wrote tests for (the changes to) my feature.

Description of changes

@maartenbreddels maartenbreddels marked this pull request as ready for review January 21, 2026 09:22
Regression test for issue widgetti#1133 where navigating back (..) from a
symlinked directory would go to the parent of the resolved symlink
target instead of the logical parent directory.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@maartenbreddels
Copy link
Copy Markdown
Contributor

Thanks for the fix! I've rebased on master and added a regression test that:

  • Fails on master - confirming the bug exists
  • Passes with your fix - confirming it works

Copy link
Copy Markdown
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maartenbreddels maartenbreddels merged commit fccfcab into widgetti:master Apr 21, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileBrowser resolves symlinks unexpectedly

3 participants