Open
Conversation
Adds a higher-level channel abstraction over the existing SSE primitives with in-memory and database adapters, a global publish() function, controller mixin for subscribeToChannel(), JS client library, and tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Wheels Test Matrix
Results for commit 0ac9e74. |
Contributor
Wheels Test Results 42 files ± 0 3 780 suites +84 25m 23s ⏱️ -43s For more details on these failures and errors, see this check. Results for commit d468c09. ± Comparison against base commit e5e2d59. ♻️ This comment has been updated with latest results. |
MySQL DATETIME and Oracle TIMESTAMP have second-level precision, so events published within the same second get identical createdAt values. The previous > comparison missed events in the same second as the reference event. Switch to >= with an explicit id != exclusion to handle all databases correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Channel.cfc) — ConcurrentHashMap-backed, instant delivery, single-serverDatabaseAdapter.cfc) —_wheels_eventstable with auto-create, poll-based, multi-serverpublish()function — call from controllers, models, jobs, anywheresubscribeToChannel()) — long-lived SSE stream with heartbeats, timeout, disconnect detectionwheels-sse.js) — zero-dependency EventSource wrapper with auto-reconnect + exponential backoff.ai/wheels/channels/channels.mdFiles
vendor/wheels/Channel.cfcvendor/wheels/channel/DatabaseAdapter.cfc_wheels_eventstable)vendor/wheels/controller/channels.cfcvendor/wheels/Global.cfcpublish()and$getChannelEngine()vendor/wheels/public/assets/js/wheels-sse.jsvendor/wheels/tests/specs/controller/channelSpec.cfcvendor/wheels/tests/specs/channel/DatabaseAdapterSpec.cfc.ai/wheels/channels/channels.mdCloses #1914
Test plan
publish()from model callback delivers tosubscribeToChannel()client🤖 Generated with Claude Code