fix: preserve LESS options in enter pager - #551
Draft
wfxr wants to merge 1 commit into
Draft
Conversation
Pass the required color and stay-open flags directly to less so forgit no longer replaces users' LESS environment options. Add regression coverage and document the default behavior.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check list
Description
Preserve user-defined
LESSoptions when opening the full-screen Enter pager. Like Git, forgit now honors an existingLESSvalue rather than replacing it; the required color and stay-open behavior is expressed through command-line options.Add regression coverage for inherited
LESSoptions and document the defaultFORGIT_ENTER_PAGERbehavior.Fixes #538.
Type of change
Test environment
Additional verification:
lib/bashunit tests(74 tests, 123 assertions), shfmt, Bash syntax check, rumdl, and ShellCheck 0.11.0 with the repository's pre-existing SC2218 findings excluded.