Stop plugin exec flashing a console window on Windows - #17
Merged
Conversation
Sinclair is a GUI app, so a console program it spawns pops a console window for as long as it runs. Every `exec` from a plugin does that - a git panel refreshing on a timer would flicker a console at you each time - and so does the curl behind `fetch`, and the taskkill that ends a timed-out program. All three now pass CREATE_NO_WINDOW. No-op off Windows, where the question does not arise. Also drops the `plugins\notes` staging from the Windows packaging that 1.32.1 fixed, and its matching MSI component, so the comment above the script no longer describes files that stopped existing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sinclair is a GUI app, so a console program it spawns pops a console window for as long as it runs. Every
execfrom a plugin does that — a git panel refreshing on a timer would flicker a console each time — and so does the curl behindfetch, and thetaskkillthat ends a timed-out program. All three now passCREATE_NO_WINDOW; no-op off Windows.Why this is a PR rather than a push to main. The
#[cfg(windows)]branch cannot be verified on the macOS dev host:cargo check --target x86_64-pc-windows-msvcdies in the C build scripts (zstd-sys,psm) before it type-checks any Rust, so a typo there would sail through locally and only surface as a failedbuild-windowsat release time — which is exactly how 1.32.0 shipped without Windows artifacts.windows.ymlruns onpull_requestforcrates/**, so this is the gate that can actually see it.