fix: fall back to POSIX ps flags on BusyBox/Alpine#16
Open
Luc0-0 wants to merge 2 commits intowebpod:mainfrom
Open
fix: fall back to POSIX ps flags on BusyBox/Alpine#16Luc0-0 wants to merge 2 commits intowebpod:mainfrom
Luc0-0 wants to merge 2 commits intowebpod:mainfrom
Conversation
BusyBox ps (common on Alpine Linux) doesn't support -lx, so it either errors out or returns its own default format that the parser can't handle. This adds a psFallback lookup using ps -eo pid,ppid,args which is POSIX-compliant and works on BusyBox.
Member
|
Can we somehow pick the proper flow here? Additional condition? |
Author
yeah, added IS_BUSYBOX using fs.existsSync('/bin/busybox') — same pattern as IS_WIN/IS_WIN2025_PLUS, picks psFallback directly instead of retrying. no runtime overhead, just a sync file check at startup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ps -lxis procps-specific and doesn't work on BusyBox (Alpine Linux). BusyBox either ignores the flags and prints its own format, or returns empty output — both cause downstream parsing issues in@webpod/ingrid.This adds a
psFallbacklookup usingps -eo pid,ppid,args(POSIX-compliant, works on BusyBox). If the primaryps -lxreturns no results, it automatically retries with the fallback.Related: google/zx#1369, webpod/ingrid#11