chore: upgrade eslint from v8 to v9#251
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 82.26% 72.99% -9.28%
==========================================
Files 4 4
Lines 141 137 -4
Branches 51 51
==========================================
- Hits 116 100 -16
- Misses 16 24 +8
- Partials 9 13 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/runtime/getGlobalThis.js
Outdated
| if (typeof window === "object") { | ||
| return window; | ||
| if (typeof globalThis.window === "object") { | ||
| return globalThis; |
There was a problem hiding this comment.
In this place lets keep window for tests, just use // eslint-disable-next-line
src/runtime/getGlobalThis.js
Outdated
| } | ||
|
|
||
| return g; | ||
| return globalObj; |
There was a problem hiding this comment.
This is a breaking change, we should keep logic without globalThis, because it will not work in old browsers
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Please fix the comment above
|
@alexander-akait done |
| // This works if eval is allowed (see CSP) | ||
| // eslint-disable-next-line no-new-func | ||
| g = this || new Function("return this")(); | ||
| } catch (e) { |
There was a problem hiding this comment.
Keep e because old browsers doesn't support optional catch
2 participants
This PR contains a:
Motivation / Use-Case
upgrade eslint from v8 to v9
Breaking Changes
No
Additional Info
No