Change RegisteredTool#inputSchema type from DOMString to object - #241
Open
beaufortfrancois wants to merge 2 commits into
Open
Change RegisteredTool#inputSchema type from DOMString to object#241beaufortfrancois wants to merge 2 commits into
RegisteredTool#inputSchema type from DOMString to object#241beaufortfrancois wants to merge 2 commits into
Conversation
domfarolino
approved these changes
Aug 12, 2026
beaufortfrancois
added a commit
to beaufortfrancois/model-context-tool-inspector
that referenced
this pull request
Aug 13, 2026
Ensure `inputSchema` is serialized to a string when returned as an object from `document.modelContext.getTools()`, aligning with the updated WebMCP specification and Chromium implementation. References: - https://chromium-review.googlesource.com/c/chromium/src/+/8248081 - webmachinelearning/webmcp#241
This was referenced Aug 13, 2026
fix: handle RegisteredTool.inputSchema as an object
beaufortfrancois/model-context-tool-inspector#34
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #237 (comment),
ModelContextTool#inputSchemawas defined as anobjectduring registration, butRegisteredTool#inputSchemareturned a stringified JSON schema (DOMString) fromgetTools().This change aligns
RegisteredTool#inputSchemato be anobject(JavaScript object), matchingModelContextTool#inputSchemaand the MCP Tool specification.Hopefully we'll apply the same reasoning to
executeTool(myTool, {})instead ofexecuteTool(myTool, '{}')in #226Preview | Diff