Carry metadata across vertex trees - #225
Merged
Merged
Conversation
A metadata row ahead of the first vertex reaches only that vertex when the surrounding names alternate prefixes, and compareAV sorts on aMeta before the Y band, so the vertex ends up last in its group while its mirror on the other side stays in front. The fixture needs alternating nl/nr names of its own because frame.jbeam calls both sides rl_f and keeps them in one chunk.
Threading the resulting metadata from the previous vertex tree when creating a new vertex tree.
The metadata threading resolved the reordering and the dropped selfCollision row, so the marker no longer describes what fails. What remains is the // support comment on rlsm, which breakVertices hands to the next tree because extractPreviousAssocCmt only inspects the head of the accumulator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.