Publish Python wheels with the next release - #91
Merged
Conversation
The release script still invokes setup.py even though the packaging migration removed it, and PyPI currently contains only a source distribution. Build and upload both Python distributions from pyproject.toml and include the MIT license in each. Closes web-push-libs#87
jrconlin
requested changes
Aug 3, 2026
jrconlin
left a comment
jrconlin
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay on this. I've been waylaid by a few other issues.
This PR looks really good, Thank You, one small issue that I hit on was that some instances of python that may not have the PYTHONPYCACHEPREFIX environment var either set or recognized could potentially pollute the package. It's more a hygiene thing for folk like me than anything else.
jrconlin
approved these changes
Aug 3, 2026
jrconlin
added a commit
that referenced
this pull request
Aug 3, 2026
This is post #91 work Co-authored-by: jrconlin <jr+git@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPI currently provides only an sdist for
http_ece, and the release script still invokessetup.pyafter its removal in #86.Read release metadata from
pyproject.toml, build and upload both an sdist and a wheel, and include the MIT license in both distributions.Closes #87