Add plumbing for safe printable inset to wptrunner and webdriver.#58030
Open
Add plumbing for safe printable inset to wptrunner and webdriver.#58030
Conversation
For print reftests, check <meta name="safe-printable-inset"> to simulate an unprintable region along the paper edges. The `content` attribute takes a non-negative number, which is the safe printable inset specified in centimeters. Only implemented for executorwebdriver. Spec discussion: w3c/csswg-drafts#11395 Spec change: w3c/csswg-drafts#13190 RFC: web-platform-tests/rfcs#233 For background, see https://drafts.csswg.org/css-page-3/#printable-area
mstensho
added a commit
to mstensho/webdriver
that referenced
this pull request
Feb 25, 2026
This is for testing the `page-margin-safety` descriptor in `@page` and page margin box contexts. Spec discussion: w3c/csswg-drafts#11395 Spec change: w3c/csswg-drafts#13190 RFC: web-platform-tests/rfcs#233 wptrunner and webdriver code changes: web-platform-tests/wpt#58030
wpt-pr-bot
added
infra
manifest
webdriver
wg-s_browser-tools-testing
wptrunner
Contributor
Author
|
The css-page spec changes have landed, and I've updated the description here accordingly. Please take a look! |
Contributor
jonathan-j-lee
left a comment
jonathan-j-lee
left a comment
There was a problem hiding this comment.
Mostly LGTM. Will stamp once the RFC lands.
Co-authored-by: Jonathan Lee <jonathan-j-lee@users.noreply.github.com>
Co-authored-by: Jonathan Lee <jonathan-j-lee@users.noreply.github.com>
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 20, 2026
All css-page/ tests are run by the content_shell WPT runner anyway, since the headless Chrome WPT runner implementation is incapable of running pagination tests reliably. Move existing printing/ tests for page margin safety to WPT. Marked as tentative for now, awaiting the following to be resolved: w3c/webdriver#1950 web-platform-tests/wpt#58030 web-platform-tests/rfcs#233 Bug: 368070327 Change-Id: I1bd05c7c10dd12f49e7bc76132138190173eb71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415846 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1617651}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
All css-page/ tests are run by the content_shell WPT runner anyway, since the headless Chrome WPT runner implementation is incapable of running pagination tests reliably. Move existing printing/ tests for page margin safety to WPT. Marked as tentative for now, awaiting the following to be resolved: w3c/webdriver#1950 #58030 web-platform-tests/rfcs#233 Bug: 368070327 Change-Id: I1bd05c7c10dd12f49e7bc76132138190173eb71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415846 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1617651}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
All css-page/ tests are run by the content_shell WPT runner anyway, since the headless Chrome WPT runner implementation is incapable of running pagination tests reliably. Move existing printing/ tests for page margin safety to WPT. Marked as tentative for now, awaiting the following to be resolved: w3c/webdriver#1950 #58030 web-platform-tests/rfcs#233 Bug: 368070327 Change-Id: I1bd05c7c10dd12f49e7bc76132138190173eb71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415846 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1617651}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For print reftests, check
<meta name="safe-printable-inset">to simulatean unprintable region along the paper edges. The
contentattributetakes a non-negative number, which is the safe printable inset specified
in centimeters.
This is for testing the
page-margin-safetydescriptor in@pageandpage margin box contexts.
Only implemented for executorwebdriver.
Spec: https://drafts.csswg.org/css-page-3/#page-margin-safety
Spec discussion: w3c/csswg-drafts#11395
RFC: web-platform-tests/rfcs#233
webdriver spec change: w3c/webdriver#1950
For background, see https://drafts.csswg.org/css-page-3/#printable-area