feat(core): preserve env presets instead of inlining#1764
Draft
elecmonkey wants to merge 1 commit into
Draft
Conversation
elecmonkey
force-pushed
the
elecmonkey/preserve-env-define
branch
2 times, most recently
from
July 14, 2026 08:10
8d72368 to
8dc0348
Compare
Keep Rsbuild's default `process.env.*` presets from being inlined for all formats, and `import.meta.env.*` for ESM, so downstream consumers can replace them. Other formats keep Rsbuild's inlining since `import.meta` is invalid there.
elecmonkey
force-pushed
the
elecmonkey/preserve-env-define
branch
from
July 14, 2026 12:09
8dc0348 to
b9afaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop inlining Rsbuild's default env presets so downstream consumers can replace them:
process.env.BASE_URL/process.env.ASSET_PREFIX: preserved for all formats.import.meta.env.*: preserved for ESM only.Need web-infra-dev/rspack#14483
Checklist