fix(core): improve nodenext type declarations#1559
Draft
Timeless0911 wants to merge 1 commit intomainfrom
Draft
Conversation
Timeless0911
force-pushed
the
david/fix/core-nodenext-types
branch
from
23d5ef2 to
8e7fbb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the core declaration output to use extension-based dts redirects instead of writing an extra
dist-types/package.json, and add dedicated bundler / NodeNext type-test fixtures undertests/type-tests.Wire those fixtures into the
@rslib/teststype-check flow so we can validate module-resolution-specific public type behavior in one place.Please wait to merge this until web-infra-dev/rspack#13376 is released.
Related Links
Checklist