Skip to content

Apply requested fix - https://github.com/web-illinois/illinois_framew…#1177

Merged
trubach merged 3 commits into4.xfrom
issue/1162-v4
Mar 27, 2026
Merged

Apply requested fix - https://github.com/web-illinois/illinois_framew…#1177
trubach merged 3 commits into4.xfrom
issue/1162-v4

Conversation

@hpleas
Copy link
Copy Markdown
Contributor

@hpleas hpleas commented Mar 4, 2026

📝 Description

Commented out script call as instructed in the comments of the ticket #1162

Fixes # Performed instructions provided here: #1162 (comment)

✅ Peer Review Checklist

Reviewers: Please verify the following before approving.

  • The pull request links to the issue it is addressing in the comment and in the "Development" section of the PR
  • There is a short summary that describes how the fix is implemented
  • Verifying work: Verify that the changes made are addressing the linked issue
  • Accessibility: Changes that might impact accessibility are reviewed to work with keyboard navigation and screen readers
  • Responsive: Layout is tested on desktop, tablet, and mobile screens
  • Config changes: Any configuration updates are tested and verified using the Distribution Update import
  • Security: Output is sanitized (using t(), Twig auto-escaping, etc.). No secrects included (API keys, etc.)
  • Cleanliness: All debug code (ksm(), dpm(), console.log) has been removed.
  • Comments: Complex logic is explained inline.
  • Documentation: Any relevant documentation has been updated (this can be a separate issue if needed)

📸 Screenshots / Video (Optional)

If this is a UI change, please attach a screenshot or a quick screen recording of the change in action.

@trubach trubach added the 4.x Work that needs to be done on the 4.x branch label Mar 4, 2026
@hpleas
Copy link
Copy Markdown
Contributor Author

hpleas commented Mar 4, 2026

Adjusted per #1162 (comment)

Copy link
Copy Markdown
Contributor

@trubach trubach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local dev and verified the code is gone from the source and the cookie banner still shows.

@trubach trubach merged commit ab4077f into 4.x Mar 27, 2026
@trubach trubach deleted the issue/1162-v4 branch March 27, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x Work that needs to be done on the 4.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Cookie Banner includes from our theme since they are included in the Toolkit

2 participants