Add effort to Search Mode - #99
Merged
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
augustas1
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Adds an optional
effort: Literal["low", "medium", "high"]parameter to Search Mode, available on bothQueryAgent.search()andAsyncQueryAgent.search(). Higher effort may improve result quality at the expense of increased latency and cost. Defaults toNone(no behavior change for existing callers).The parameter is threaded through the searcher and stored on it, so it persists across pagination,
response.next()sends the sameeffortvalue on every page. This follows the same pattern as the existingfilteringanddiversity_weightparameters.Changes
weaviate_agents/query/classes/request.py: addeffortfield toSearchModeRequestBase(included in both generation and execution requests)weaviate_agents/query/search.py: accept and storeefforton_BaseQueryAgentSearcher, include it in request bodiesweaviate_agents/query/query_agent.py: addeffortparameter to sync and asyncsearch()with docstringstest/query_agent/test_query_model.py: tests for effort being sent, persisting across pagination, and defaulting toNone