Conversation
dati18
force-pushed
the
T434193
branch
4 times, most recently
from
August 19, 2026 12:11
c04bf07 to
1702611
Compare
rosalieper
commented
Aug 20, 2026
rosalieper
left a comment
rosalieper
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM. I will still appreciate another eye on this as I have commits on this PR.
Member
There was a problem hiding this comment.
Have tested that this works as I expect locally, and the code looks good.
- Please update the PR title and description so I can review the commit message.
- Looks like this PR needs updating with changes from
main.
After that, I think it's good to go for an approval and merge.
- Add alert for outdated version of policy - Move the alert to apear under the page title Bug: T434193
- Add `Effective` date in the subheader of the HP and ToU pages - In the policy navigation panel, the ToU versions' titles are formatted to `<DD Month YYYY> (current)` (e.g., `1 January 2022 (current)` or `1 January 2021`, not `Current version` or `2021-01-01`) Bug: T434191 --------- Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
- Add `Effective` date in the subheader of the HP and ToU pages - In the policy navigation panel, the ToU versions' titles are formatted to `<DD Month YYYY> (current)` (e.g., `1 January 2022 (current)` or `1 January 2021`, not `Current version` or `2021-01-01`) Bug: T434191 --------- Co-authored-by: Ollie <43674967+outdooracorn@users.noreply.github.com>
dati18
changed the title
outdooracorn
changed the title
outdooracorn
approved these changes
Aug 21, 2026
outdooracorn
left a comment
outdooracorn
left a comment
Member
There was a problem hiding this comment.
LGTM! 
Have tweaked the commit title and body slightly.
REMINDER: When squash & merging, don't forget to make sure the commit message is correct. GitHub likes to mess up our Bug: git trailers when it adds co-authored-by: git trailers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effective:subheading isn't displayed, the spacing between the title heading and the info banners is visually similar to the spacing between the title heading and theEffective:subheading, when it is displayed.Bug: T434193