Skip to content

Add hints for when to use the example development .env files#1107

Open
outdooracorn wants to merge 2 commits intomainfrom
example-env-hints
Open

Add hints for when to use the example development .env files#1107
outdooracorn wants to merge 2 commits intomainfrom
example-env-hints

Conversation

@outdooracorn
Copy link
Member

@outdooracorn outdooracorn commented Mar 19, 2026

Bug: T420581

@outdooracorn outdooracorn self-assigned this Mar 19, 2026
@github-actions
Copy link

Deployment previews on netlify for branch refs/pull/1107/merge will be at the following locations (when build is done):

Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these descriptions aren't right. I'm not actually 100% sure though

@@ -1,3 +1,4 @@
# For local development using docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

I saw it was introduced in #824 and I think this is the context it's intended to be used in

Suggested change
# For local development using docker
# For running GitHub Actions tests using docker

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out.

I think it might be for both then?

I might be missing something, but I don't see how .env.development.local which sets VUE_APP_API_URL=http://localhost:8082 can work in a local docker environment as localhost will resolve to the UI docker container.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local docker environment as localhost will resolve to the UI docker container.

I think not. I think it will resolve to 127.0.0.1 and I assume you aren't using a browser in docker but just a normal browser on the host?

I think VUE_APP_API_URL=http://localhost:8082 is designed for local development. e.g. incombination with the docker-compose dev environment from the API repo (https://github.com/wbstack/api/blob/main/docker-compose.yml#L12) or perhaps from kubectl port-forward deployment/api-app-backend 8082:80 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh of course! The UI is all client side. Thanks for fixing my brain there. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I think you might actually be right and I am even more confused. There is also this

target: process.env.VUE_APP_API_URL,
which is a server side proxy :/

Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants