Add hints for when to use the example development .env files#1107
Add hints for when to use the example development .env files#1107outdooracorn wants to merge 2 commits intomainfrom
Conversation
|
Deployment previews on netlify for branch
|
.env.development.test
Outdated
| @@ -1,3 +1,4 @@ | |||
| # For local development using docker | |||
There was a problem hiding this comment.
Is this right?
I saw it was introduced in #824 and I think this is the context it's intended to be used in
| # For local development using docker | |
| # For running GitHub Actions tests using docker |
There was a problem hiding this comment.
Thanks for pointing this out.
I think it might be for both then?
I might be missing something, but I don't see how .env.development.local which sets VUE_APP_API_URL=http://localhost:8082 can work in a local docker environment as localhost will resolve to the UI docker container.
There was a problem hiding this comment.
local docker environment as localhost will resolve to the UI docker container.
I think not. I think it will resolve to 127.0.0.1 and I assume you aren't using a browser in docker but just a normal browser on the host?
I think VUE_APP_API_URL=http://localhost:8082 is designed for local development. e.g. incombination with the docker-compose dev environment from the API repo (https://github.com/wbstack/api/blob/main/docker-compose.yml#L12) or perhaps from kubectl port-forward deployment/api-app-backend 8082:80 ?
There was a problem hiding this comment.
Ahhhh of course! The UI is all client side. Thanks for fixing my brain there. :)
There was a problem hiding this comment.
no I think you might actually be right and I am even more confused. There is also this
Line 6 in d3c3e8a
Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
Bug: T420581