Use more meaningful names for step cards in CreateWikiWizard#1106
Use more meaningful names for step cards in CreateWikiWizard#1106outdooracorn wants to merge 5 commits intomainfrom
Conversation
* Move `TemporalityProfileEditWizardStep` to where it is used in `Pages/ManageWiki/cards` * Remove `dissmissable` property from `TemporalityCreateWikiWizardStep` and the optional close-dialog icon that will never be displayed * Remove `dissmissable` property from `TemporalityProfileEditWizardStep` and the `v-if` logic for the close-dialog icon as that will always be displayed * Remove unused `buttonText` property from `CreateWiki`
|
Deployment previews on netlify for branch
|
|
Not sure how I feel about this but thought I'd put it up for others to have a look at. If we like this, we should do the same for |
| otherAudience: '' | ||
| }, | ||
| stepThree: { | ||
| temporality: { |
There was a problem hiding this comment.
what do you think of adding the word "step" to this names, so that we do not have to reference it with temporality.temporality.
There was a problem hiding this comment.
Nice idea I think I like that too. I think specifically this is looking at R135 below
Yes, I like this! Thank you Ollie |
3 participants
Bug: T419207