Refactor Create Wizard Cards in Platform UI#1105
Merged
outdooracorn merged 5 commits intomainfrom Mar 19, 2026
Merged
Conversation
|
Deployment previews on netlify for branch
|
tarrow
requested changes
Mar 11, 2026
rosalieper
changed the title
* Move `TemporalityProfileEditWizardStep` to where it is used in `Pages/ManageWiki/cards` * Remove `dissmissable` property from `TemporalityCreateWikiWizardStep` and the optional close-dialog icon that will never be displayed * Remove `dissmissable` property from `TemporalityProfileEditWizardStep` and the `v-if` logic for the close-dialog icon as that will always be displayed * Remove unused `buttonText` property from `CreateWiki`
tarrow
reviewed
Mar 19, 2026
tarrow
requested changes
Mar 19, 2026
Contributor
tarrow
left a comment
tarrow
left a comment
There was a problem hiding this comment.
Looks basically fine to me now. I saw one more bit of refactoring (that's actually in addition that specified in the ticket. Specifically, removing the dismissable prop.
I think it needs one more line removing which I've suggested. I then have no more review and am happy for it to be merged when you are both happy.
Co-authored-by: Thomas Arrow <tarrow@users.noreply.github.com>
tarrow
approved these changes
Mar 19, 2026
outdooracorn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemporalityCreateWikiWizardStepcard (based on the existingStepThreeCard) for use only in the create wiki wizardStepThreeCardtoTemporalityCreateWikiWizardStepfor use only when editing the profileTemporalityProfileEditWizardStepto where it is used inPages/ManageWiki/cardsas it is no long a component used in multiple parts of the codebasesubmitButtonTextabstraction logic from theTemporalityCreateWikiWizardStepandTemporalityProfileEditWizardStepcards. As they are no longer reused each card can hard code the correct value.dissmissableproperty fromTemporalityCreateWikiWizardStep, and the optional close-dialog icon that will never be displayeddissmissableproperty fromTemporalityProfileEditWizardStep, and thev-iflogic for the close-dialog icon as that will always be displayedbuttonTextproperty fromCreateWikiBug: T419207