docs: polished animated SVG demo (3 scenes), retire the VHS path#21
Merged
Conversation
Brings back the deterministic SMIL-SVG generator (vector, tiny, no network) with the curated forged scenes — both valid pdcli commands (pipeline health; deal update --status won). Polish vs the old one: WIDTH 720→880, font 14→15px, LINE_H 22→26, scaled padding/caret, so nothing crowds the edge. README points back at docs/demo.svg; docs:demo runs the generator again. The VHS path (demo.tape + seed-demo.sh + demo.webp) stays in the tree as the live-recording alternative — this branch is for side-by-side comparison.
…crop
CH (the clip/caret glyph width) was 9.0px but real 15px monospace advance is
wider, so the typing clip cut the command ('health' → 'heal') and parked the
caret mid-word. Bump CH to a safe over-estimate (10.0); the command now fully
reveals on the fonts in the stack, caret sits just after it.
The typing/output reveals fired once but the doc 'looped' every 12s without re-triggering them, so after the first pass the command never re-revealed — renderers landed on degenerate frames (bare prompt + caret). Drop the loop: the demo now types scene 1, then scene 2, and rests on the won-confirmation (last scene never resets/hides; its caret blinks on the resting frame). No loop state to degenerate, robust across SVG renderers.
… cut The command's typing clip-rect bottom sat exactly on the text baseline, shearing glyph descenders (the tails of p/g/y in 'pdcli'/'pipeline'). Extend the rect 10px past the baseline so descenders render in full.
Rounds the arc see → act → improve: pipeline health, a won deal, then an audit that surfaces duplicate/stale/next-step findings (amber ● markers) with a --strict CI hint. Showcases the value-add beyond CRUD. New .warn color; the demo plays through three scenes and rests on the audit.
Sizing the held clip to an estimated cmdW still shaved the last glyph when the
viewer's real advance ran over the estimate ('audit' -> 'audi'). Now the clip
grows to ~cmdW while typing, then snaps to full width at typing-end — the
resting command is never cropped, independent of the rendering font. CH (11)
now only paces the type animation and the caret.
Going with the curated SMIL-SVG demo (crisper, tiny, deterministic). Remove the VHS recording files (docs/demo.tape, scripts/seed-demo.sh, docs/demo.webp) and the stale CONTRIBUTING mention; refresh the README alt text for the 3 scenes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the README demo with a polished, curated SMIL-SVG terminal — crisper than the WebP (vector, ~4 KB, scales at any DPI), deterministic, no network/fonts/scripts.
Scenes (see → act → improve):
pdcli pipeline health— the pipeline tablepdcli deal update 4821 --status won— ✓ confirmationpdcli audit— data-hygiene findings (● duplicates/stale, --strict CI hint)Generator fixes (
scripts/gen-demo.mjs) over the old version:Retires the VHS path (
docs/demo.tape,scripts/seed-demo.sh,docs/demo.webp). 1503 tests, 100% coverage, lint clean. Docs-only.