Skip to content

Merge ModuleConfig trait into ChiselModule#198

Merged
axic merged 1 commit intomasterfrom
module-config
Jan 19, 2020
Merged

Merge ModuleConfig trait into ChiselModule#198
axic merged 1 commit intomasterfrom
module-config

Conversation

@axic
Copy link
Copy Markdown
Member

@axic axic commented Jan 18, 2020

No description provided.

@axic axic requested a review from jakelang January 18, 2020 23:39
@axic axic mentioned this pull request Jan 18, 2020
Merged
jakelang
jakelang approved these changes Jan 19, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jakelang jakelang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that #197 does part of it, but why not just scrap the old methods from ChiselModule?

@axic
Copy link
Copy Markdown
Member Author

axic commented Jan 19, 2020

but why not just scrap the old methods from ChiselModule?

You can once #172 is done.

@axic axic merged commit e82fd3b into master Jan 19, 2020
@axic axic deleted the module-config branch January 19, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelang jakelang jakelang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axic @jakelang