Conversation
gumb0
reviewed
Sep 11, 2020
gumb0
force-pushed
the
public_capi
branch
2 times, most recently
from
d40c76f to
de60a34
Compare
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 59 61 +2
Lines 8948 8959 +11
=======================================
+ Hits 8827 8838 +11
Misses 121 121 |
gumb0
approved these changes
Sep 17, 2020
Member
|
Should add an install target to this, or in a new PR to be merged before. |
axic
reviewed
Sep 21, 2020
axic
reviewed
Sep 21, 2020
Collaborator
Author
Added here. |
Member
|
Do we want to add a |
Collaborator
Author
Add it where? |
Member
|
|
Collaborator
Author
|
So far I was successfully avoiding version macros. |
axic
reviewed
Sep 22, 2020
test/unittests/capi_test.cpp
Outdated
| #include <fizzy/fizzy.h> | ||
| #include <gtest/gtest.h> | ||
|
|
||
| TEST(capi, fizzy_validate) |
Member
There was a problem hiding this comment.
#533 does not use the fizzy_ prefix here. Do we want to follow?
Collaborator
Author
There was a problem hiding this comment.
I'm forward-following now.
Closed
chfast
force-pushed
the
public_capi
branch
2 times, most recently
from
266a792 to
98a135c
Compare
gumb0
approved these changes
Sep 25, 2020
axic
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.