Skip to content

docs: improve release note guidance#73

Merged
wasabeef merged 3 commits into
mainfrom
docs/release-note-quality
May 12, 2026
Merged

docs: improve release note guidance#73
wasabeef merged 3 commits into
mainfrom
docs/release-note-quality

Conversation

@wasabeef
Copy link
Copy Markdown
Owner

@wasabeef wasabeef commented May 12, 2026

Pull Request

Summary

Improve the maintainer guidance and generator behavior that control release-note quality.

  • Clarifies that GitHub Releases are generated from commit subjects and Release note: commit-body lines, not PR titles.
  • Adds explicit guidance for multi-commit PRs so review-fix follow-up commits usually use Release note: skip.
  • Capitalizes the first rendered character of generated release-note bullets as a safety net for lower-case conventional commit subjects.
  • Updates the PR template with a Release Note Plan section so release wording is decided before merge.
  • Updates the release procedure to require reviewing generated git-cliff output before tagging.

Release Note Plan

Release note: skip

This is maintainer-process guidance. It should prevent future low-level release notes, but it does not change user-facing Agent Note behavior.

Type of Change

  • Fix
  • Feature
  • Documentation
  • Refactor
  • Test
  • CI / release

Checklist

  • I kept structural changes separate from behavior changes where practical.
  • I added or updated tests for behavior changes.
  • I updated README / docs / website content when user-facing behavior changed.
  • I rebuilt generated bundles when bundled source changed.
  • I ran the relevant checks locally.

Notes for Reviewers

I also manually rewrote the already-published v1.0.0 and v1.0.1 GitHub Release bodies so those two public release notes read like product updates instead of implementation logs.

Verification:

  • git diff --check
  • git-cliff --config .github/cliff.toml --latest --strip header

Summary by CodeRabbit

  • Documentation
    • Added a “Release Note Plan” to the PR workflow and expanded guidance so authors write concise, user-facing release notes (one bullet per visible change; use “skip” for follow-ups).
    • Updated engineering and architecture guidance to require previewing and editing generated release notes before tagging.
    • Adjusted changelog formatting to normalize and capitalize release-note bullets.

Review Change Stack

🧑💬🤖 Agent Note

Total AI Ratio: ████████ 100%
Model: gpt-5.4

Commit AI Ratio Prompts Files
597c6f9 docs: improve release note guidance █████ 100% 1 PULL_REQUEST_TEMPLATE.md 🤖, AGENTS.md 🤖, CLAUDE.md 🤖, architecture.md 🤖, engineering.md 🤖
fd938a6 docs: capitalize generated release notes █████ 100% 1 cliff.toml 🤖, AGENTS.md 🤖, CLAUDE.md 🤖, architecture.md 🤖, engineering.md 🤖
0047bab docs: clarify release note follow-up wording █████ 100% 1 engineering.md 🤖
💬 Prompts & Responses (3 total)

597c6f9 docs: improve release note guidance

🧑 Prompt
https://github.com/wasabeef/AgentNote/releases/tag/v1.0.1

リリースノートみると意味があるものになっていないので、よりよいものにしたい
これは PR タイトルから生成しているのであれば、 CLAUDE.md AGENTS.md などでタイトルの質をあげるようにしてほしい

🤖 Response
リリースノートの生成元をまず確認します。PR タイトル起点なのか、commit subject / body / git-cliff 設定起点なのかを切り分けてから、AGENTS.md / CLAUDE.md 側に効くルールとして直します。
確認したところ、v1.0.1 の Release body は PR タイトルではなく git-cliff が commit subject / Release note: body から生成しています。つまり改善すべき中心は「PR タイトル」だけではなく、AI Agent が作る commit subject / commit body / PR title を同時に揃えるルールです。
v1.0.1 が読みにくくなった原因は、同じ修正領域の incremental fix commits がすべて fix: として release notes に載ったことでした。対策として、AI Agent には「公開 bullet は primary commit に集約し、review follow-up は `Release note: ski…

fd938a6 docs: capitalize generated release notes

🧑 Prompt
それと、リリースノート生成時に頭文字が小文字だったら大文字にしたほうがいいんじゃないか?置換で。
英文的には。

🤖 Response
賛成です。fix: / feat: の conventional commit subject は英語だと動詞始まりになりやすいので、release note bullet では Generate... のように先頭大文字へ正規化した方が読みやすいです。git-cliff の template 側で upper_first を噛ませれば、PR / commit 運用に頼りきらず最低限の見た目を揃えられます。
実装は .github/cliff.toml の template を直すだけで済みます。あわせて docs 側に「generator が safety net として先頭を大文字化するが、人間/Agent は最初から自然な英文を書く」ルールも残します。
upper_first を入れました。これで自動生成時に recover... のような bullet は Recover... になります。念のため、実際の git-cliff 出力で v1.0.1 の先頭小文字 bullet が大文字化されることを確認します。
確認できました。`git-…

0047bab docs: clarify release note follow-up wording

🧑 Prompt
$coderabbit-review

🤖 Response
coderabbit-review skill を使います。まず PR #73 の CodeRabbit 指摘を thread 単位で確認し、対応すべきものだけ直して、対応済みだけ resolve します。並行して、先ほど消した Agent Note は body 保持更新で復元します。
まず #73 の CodeRabbit thread を取得します。指摘があれば、source を確認して「修正する / コメントで理由を返す / 何もしない」を分けます。PR body は、Agent Note と CodeRabbit の自動コメントを両方残す形にしてから更新します。
CodeRabbit の未解決 thread は 1 件だけで、docs/engineering.md の “Review follow-up commits” が少し曖昧という nit です。これは妥当なので、最小修正します。PR body はこの後 push して CI の PR Report に再生成させる流れにします。手動で body 全体を上書きしません。
修正は CodeRabbit の sugg…

Why
v1.0.1 generated a low-level release note because several review follow-up commits were visible as release bullets.

User impact
Maintainers and AI agents now have clearer rules for PR titles, commit bodies, and Release note lines before tagging.

Verification
- git diff --check

Release note: skip
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

📝 Walkthrough

Walkthrough

Adds a "Release Note Plan" prompt to the PR template, updates agent/maintainer docs with rules for writing human-sized release notes and Release note: skip usage, tweaks .github/cliff.toml to uppercase bullets, and adds pre-tagging and multi-commit guidance in architecture/engineering docs.

Changes

Release Note Standards

Layer / File(s) Summary
Release note prompt and core principles
.github/PULL_REQUEST_TEMPLATE.md, AGENTS.md, CLAUDE.md, .github/cliff.toml
Adds a "Release Note Plan" section to the PR template; AGENTS.md and CLAUDE.md add rules to write human-sized release notes, use Release note: skip for follow-ups, ensure PR titles are release-summary quality, and preview git-cliff output. .github/cliff.toml now applies upper_first to release-note bullets.
Release procedure and architecture guidance
docs/architecture.md
Documents that GitHub Release notes should be derived from commit subjects and Release note: markers, instructs keeping primary implementation commits visible, marking review-fix follow-ups with Release note: skip, and adds a pre-tag step to rewrite commits when generated notes read like implementation logs.
Multi-commit PR structure and follow-up guidance
docs/engineering.md
Adds a git-cliff pre-tag verification step, provides a preferred release-note structure example for multi-commit PRs (Why/impact/Verification/Release note), and instructs follow-up review commits to usually include Release note: skip.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • wasabeef/AgentNote#65: Both PRs modify .github/PULL_REQUEST_TEMPLATE.md and related release-note guidance.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'docs: improve release note guidance' directly and accurately summarizes the main change—updates to documentation and maintainer guidance around release note quality and practices.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/release-note-quality

Comment @coderabbitai help to get the list of available commands and usage tips.

Why
Generated release notes can inherit lower-case imperative commit subjects, which reads awkwardly in English release bullets.

User impact
Future generated release notes capitalize the first rendered character while still requiring clear human-written release wording.

Verification
- git-cliff --config .github/cliff.toml --latest --strip header
- git diff --check

Release note: skip
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/engineering.md`:
- Around line 108-111: Replace the ambiguous phrase "Review follow-up commits
should usually be `Release note: skip`" with a clearer wording such as
"Review-fix follow-up commits in a multi-commit PR should usually use `Release
note: skip`" so it's explicit this refers to commits addressing review feedback
(not the review process); update the sentence in the paragraph that currently
begins with "Keep multi-commit PRs readable..." and ensure the backtick style
for `Release note: skip` is preserved.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad4957c4-71d3-459e-bb16-80176b43e505

📥 Commits

Reviewing files that changed from the base of the PR and between 597c6f9 and fd938a6.

📒 Files selected for processing (5)
  • .github/cliff.toml
  • AGENTS.md
  • CLAUDE.md
  • docs/architecture.md
  • docs/engineering.md

Comment thread docs/engineering.md Outdated
Why
CodeRabbit flagged that the phrase Review follow-up commits could be misread as referring to the review process instead of commits that address review feedback.

User impact
Maintainer guidance now makes the intended release-note skip rule clearer for multi-commit PRs.

Verification
- git diff --check

Release note: skip
@wasabeef wasabeef merged commit f3bf00a into main May 12, 2026
11 checks passed
@wasabeef wasabeef deleted the docs/release-note-quality branch May 12, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant