Keep up/down arrow keys inside queued-prompt inline editor#12591
Open
harryalbert wants to merge 1 commit into
Open
Keep up/down arrow keys inside queued-prompt inline editor#12591harryalbert wants to merge 1 commit into
harryalbert wants to merge 1 commit into
Conversation
harryalbert
force-pushed
the
oz-agent/block-up-down-key-propagation-in-queued-prompts-edit
branch
from
ce670fd to
532d4e6
Compare
When editing a prompt in the queued prompts panel, up/down arrow keys previously propagated out of the inline editor to the host input, opening the history menu (and other inline menus) instead of moving the cursor between lines. Switch the inline edit editor's vertical navigation propagation from `Always` to `Never` so arrow keys stay inside the editor while editing. Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
oz-agent/block-up-down-key-propagation-in-queued-prompts-edit
branch
from
532d4e6 to
b6f0fa6
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR changes the queued-prompt inline editor so up/down arrow keys are handled by the editor instead of propagating to the host input while editing a row.
Concerns
- For this user-facing keyboard behavior change, please include screenshots or a short screen recording demonstrating the queued-prompt inline editor keeping up/down arrow keys inside the edit box end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Up/down arrow key interactions shouldn't be propagated when you're editing a prompt in the queued prompt panel.
Agent Mode
Conversation: https://staging.warp.dev/conversation/756c86d3-95bc-4759-b2ac-a3c231d27fd2
Run: https://oz.staging.warp.dev/runs/019ebd3f-7b80-7164-8bca-9bd540b2ee38
This PR was generated with Oz.