docs: fix lws_get_urlarg_by_name_safe() buf param description#3565
Closed
pppaulpeter wants to merge 30 commits intowarmcat:mainfrom
Closed
docs: fix lws_get_urlarg_by_name_safe() buf param description#3565pppaulpeter wants to merge 30 commits intowarmcat:mainfrom
pppaulpeter wants to merge 30 commits intowarmcat:mainfrom
Conversation
The comment said buf receives the urlarg "including the name= part" but the implementation strips the name= prefix via memmove before returning, so buf contains only the value. Also clarify that buf must be large enough for the full "name=value" fragment plus 2 bytes to satisfy the internal fraglen + 1 < len guard. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lws-team
force-pushed
the
main
branch
8 times, most recently
from
e601808 to
250ebbd
Compare
Author
|
Already applied to main via 535c903. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\param bufcomment said buf receives the urlarg "including the name= part", but the implementation strips thename=prefix viamemmovebefore returning — buf actually contains only the valuename=valuefragment plus 2 bytes to pass the internalfraglen + 1 < lenguardContext
Discovered while using
lws_get_urlarg_by_name_safe()for WebSocket token auth — undersized buffer caused silent lookup failures becausefraglen + 1 < lenrejected the match.🤖 Generated with Claude Code