Finish currently partially implemented support for setting the api-key/url in zed's settings#12
Merged
bestgopher merged 1 commit intowakatime:masterfrom Mar 14, 2025
Merged
Conversation
Collaborator
|
Hi, we can retrieve the settings when calling |
Contributor
Author
Okay, done. |
Collaborator
|
Thx, i will review it later. |
Collaborator
|
How did you install the dev version of the extension?I encountered this issue: zed-industries/zed#26750 |
Contributor
Author
I only changed wakatime-ls so I just added it to path and used extension in store to test. |
Collaborator
Ok. LGTM. I will test it later and release a new version. |
bestgopher
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the support for parsing LSP settings set in zed's settings.json was partially implemented, mentioned in the README and then never finished. These changes get it fully working on my computer so a
.wakatime.cfgfile placed in the user's home directoy is not required.