Fix time tracking for languages with primary LSP (e.g. Python) #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Time tracking is significantly under-reported for Python files. For example, 4+ hours of editing results in only ~20 minutes being recorded. Other languages work correctly.
Root Cause
Python has Pyright as the built-in/primary language server in Zed. When multiple LSPs are registered for the same language, Zed may not route all text document events to secondary language servers like wakatime-ls.
The current LSP capability declaration uses the minimal
TextDocumentSyncKind::INCREMENTALwhich doesn't explicitly request open/close and save notifications.Related: zed-industries/zed#24100
Fix
TextDocumentSyncOptionsinstead ofTextDocumentSyncKindto explicitly declare that wakatime-ls needsopen_close,change, andsaveevents