tests: add expand #t0132 (@base vs property keys)#686
Open
anatoly-scherbakov wants to merge 9 commits into
Open
tests: add expand #t0132 (@base vs property keys)#686anatoly-scherbakov wants to merge 9 commits into
anatoly-scherbakov wants to merge 9 commits into
Conversation
Contributor
Author
|
My agent fixed |
TallTed
reviewed
Apr 13, 2026
TallTed
reviewed
Apr 13, 2026
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
TallTed
reviewed
Apr 16, 2026
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
pchampin
approved these changes
May 29, 2026
Contributor
pchampin
left a comment
pchampin
left a comment
There was a problem hiding this comment.
My agent fixed LoadDocumentOptions once again after #684,
you should train it to behave!
that commit can be easily removed while rebasing if that PR, or its predecessor, is merged.
Please do make these changes before submitting the PR (like cherrypicking or rebasing locally). This may creates unnecessary friction when we decide to merge that.
Apart from this, the test looks good to me.
Co-authored-by: Pierre-Antoine Champin <pierre-antoine@w3.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ExpandTest
#t0132: with a context that sets only@base(and@version1.1), an unmapped simple property key likenameis dropped, while a relative@typetoken still resolves against that base (IRI Expansion).Files
tests/expand/0132-in.jsonld,tests/expand/0132-out.jsonldtests/expand-manifest.jsonld— new sequence entry after#t0131tests/expand-manifest.html— regenerated (Haml + HtmlBeautifier;bundle exec rakewas not runnable here without libyaml-dev; same pipeline astests/Rakefile)Preview | Diff