Use HTTP Semantics for accept option#267
Merged
Conversation
TallTed
approved these changes
Jan 9, 2026
wip-abramson
approved these changes
Jan 12, 2026
peacekeeper
approved these changes
Jan 15, 2026
dmitrizagidulin
approved these changes
Jan 22, 2026
Collaborator
dmitrizagidulin
left a comment
There was a problem hiding this comment.
👍 looks good, just needs resolving rebase conflict.
TallTed
reviewed
Jan 26, 2026
Comment on lines
+579
to
+586
| The media type of the caller's preferred <a>representation</a> of the | ||
| <a>DID document</a>. The value MUST be expressed according to the | ||
| `Accept` header value as defined in [[[RFC9110]]], <a | ||
| data-cite="RFC9110#section-12.5.1">Section 12.5.1</a>. The <a>DID | ||
| resolver</a> implementation SHOULD use this value to determine the | ||
| <a>representation</a> of the returned | ||
| <code>didDocument</code> if such a <a>representation</a> is supported | ||
| and available. This property is OPTIONAL. |
Member
There was a problem hiding this comment.
Suggested change
| The media type of the caller's preferred <a>representation</a> of the | |
| <a>DID document</a>. The value MUST be expressed according to the | |
| `Accept` header value as defined in [[[RFC9110]]], <a | |
| data-cite="RFC9110#section-12.5.1">Section 12.5.1</a>. The <a>DID | |
| resolver</a> implementation SHOULD use this value to determine the | |
| <a>representation</a> of the returned | |
| <code>didDocument</code> if such a <a>representation</a> is supported | |
| and available. This property is OPTIONAL. | |
| The media type of the caller's preferred <a>representation</a> of the | |
| <a>DID document</a>. The value MUST be expressed according to the | |
| `Accept` header value definition in [[[RFC9110]]], <a | |
| data-cite="RFC9110#section-12.5.1">Section 12.5.1</a>. The <a>DID | |
| resolver</a> implementation SHOULD use this value to determine the | |
| <a>representation</a> of the returned | |
| <code>didDocument</code> if such a <a>representation</a> is supported | |
| and available. This property is OPTIONAL. |
TallTed
reviewed
Jan 26, 2026
Comment on lines
+1191
to
+1197
| The media type that the caller prefers for <code>contentStream</code>. | ||
| The value MUST be expressed according to the `Accept` header value as | ||
| defined in [[[RFC9110]]], <a data-cite="RFC9110#section-12.5.1">Section | ||
| 12.5.1</a>. The <a>DID URL dereferencer</a> implementation SHOULD use | ||
| this value to determine the <code>contentType</code> of the | ||
| <a>representation</a> contained in the returned value if such a | ||
| <a>representation</a> is supported and available. |
Member
There was a problem hiding this comment.
Suggested change
| The media type that the caller prefers for <code>contentStream</code>. | |
| The value MUST be expressed according to the `Accept` header value as | |
| defined in [[[RFC9110]]], <a data-cite="RFC9110#section-12.5.1">Section | |
| 12.5.1</a>. The <a>DID URL dereferencer</a> implementation SHOULD use | |
| this value to determine the <code>contentType</code> of the | |
| <a>representation</a> contained in the returned value if such a | |
| <a>representation</a> is supported and available. | |
| The media type that the caller prefers for <code>contentStream</code>. | |
| The value MUST be expressed according to the `Accept` header value | |
| definition in [[[RFC9110]]], <a data-cite="RFC9110#section-12.5.1">Section | |
| 12.5.1</a>. The <a>DID URL dereferencer</a> implementation SHOULD use | |
| this value to determine the <code>contentType</code> of the | |
| <a>representation</a> contained in the returned value if such a | |
| <a>representation</a> is supported and available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address issue #116 by modelling the value of the
acceptoption according to RFC9110 (HTTP Semantics).Preview | Diff